Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some placeholder images/pages #122

Open
tacman opened this issue Mar 9, 2024 · 2 comments
Open

Add some placeholder images/pages #122

tacman opened this issue Mar 9, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@tacman
Copy link
Contributor

tacman commented Mar 9, 2024

Description

It'd be nice to have some placeholder images that can be overridden and customized but worked out of the box

For example.

            offline_fallback:
               
                image: 'images/offline.svg'

We'd need to find some open source or cc-no-attribution files, of course.

Similarly, we could add some default pages for offline at bundle level. I'll experiment with that in pwa-extra-bundle.

Example

No response

@Spomky
Copy link
Member

Spomky commented Mar 11, 2024

The problem is that if any of the offline_fallback option is set, then the offline feature is enabled. Some users may want to keep it disabled.

@tacman
Copy link
Contributor Author

tacman commented Mar 11, 2024

How about adding the assets to the repo, but commenting them out in the yaml.

In particular, an offline.svg in the bundle would safe the effort of looking one up when the default might be fine.

@Spomky Spomky self-assigned this Mar 21, 2024
@Spomky Spomky added the enhancement New feature or request label Mar 21, 2024
@Spomky Spomky added this to the 1.2.0 milestone Mar 21, 2024
@Spomky Spomky modified the milestones: 1.2.0, 2.0.0 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants