Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Whitelist format of key HTTP request headers #1144

Open
dune73 opened this issue Jul 12, 2018 · 5 comments
Open

Whitelist format of key HTTP request headers #1144

dune73 opened this issue Jul 12, 2018 · 5 comments

Comments

@dune73
Copy link
Contributor

dune73 commented Jul 12, 2018

We are blacklisting illegal request headers, but with Apache concatenating duplicate headers before we get a chance to count them etc. it makes sense to whitelist the format of several request headers.

Candidates:

  • Host
  • Accept
  • Accept-Language (benefit?)
  • Accept-Encoding
  • Cache-Control (benefit?)
  • Connection
  • Content-Type
  • Cookie (viable?)
  • If-Modified-Since (benefit?)
  • Range
  • Referer (viable?)
  • User-Agent (viable?)

This is meant for CRS 3.2.

Also see #1137.

@ghost
Copy link

ghost commented Jan 24, 2019

Let me look into this. I've studied these headers pretty extensively. There are over 100 ones, including crazy ones that are deprecated but you see a lot in legacy apps that might use ModSecurity such as the Pragma header.

@dune73
Copy link
Contributor Author

dune73 commented Jan 24, 2019

Compared to the other issue you picked, this one is really big and complex as it touches on many different aspects of CRS. If you pick this, it will accompany you for months. By the end, you will understand the inner mechanics of CRS throughly, but you could also become overwhelmed along the way. Unsure how to advice you. Smaller bites are probably easier to swallow.

@ghost
Copy link

ghost commented Jan 24, 2019

Thanks for the heads up @dune73. Glad I didn't walk into this thinking it was way easier than it actually was. Will not do for the time being.

@fgsch fgsch removed this from the CRS v3.2.0 milestone Oct 20, 2019
@github-actions
Copy link

This issue has been open 120 days with no activity. Remove the stale label or comment, or this will be closed in 14 days

@github-actions github-actions bot added the Stale issue This issue has been open 120 days with no activity. label Feb 18, 2020
@github-actions github-actions bot closed this as completed Mar 3, 2020
@dune73 dune73 reopened this Mar 3, 2020
@dune73
Copy link
Contributor Author

dune73 commented Mar 3, 2020

I still plan to follow up on this.

@dune73 dune73 removed the Stale issue This issue has been open 120 days with no activity. label Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants