Create multiple temp files instead of waiting for mutex

Author: pergerch

src/ContextMenuUploader/Program.cs

@@ -9,10 +9,10 @@ namespace ContextMenuUploader;
 public class Program
 {
 	private const string AppName = "ContextMenuUploader";
-	private const int BatchTimeoutMs = 1000; // Timeout in milliseconds to wait for more files to be selected
+	private const int BatchTimeoutMs = 500; // Timeout in milliseconds to wait for more files to be selected
 	private const string ContextMenuLabel = "Upload to web service";
 	private const string MutexName = "Global\\ContextMenuUploader";
-	private static readonly string TempFilePath = Path.Combine(Path.GetTempPath(), "ContextMenuUploader.txt");
+	private static readonly string TempFilePath = Path.Combine(Path.GetTempPath(), "ContextMenuUploader");
 
 	[STAThread]
 	public static async Task Main(string[] args)
@@ -44,8 +44,12 @@ public static async Task Main(string[] args)
 
 	private static async Task HandleFileActionAsync(string[] newPaths)
 	{
-		// Add new paths to the temporary file
-		newPaths.SafelyWriteLinesToFile(Program.TempFilePath, false);
+		// Ensure the temporary directory exists
+		Directory.CreateDirectory(Program.TempFilePath);
+
+		// Add new paths to a temporary file
+		string randomFile = Path.Combine(Program.TempFilePath, Path.GetRandomFileName());
+		await File.AppendAllLinesAsync(randomFile, newPaths);
 
 		using Mutex mutex = new(true, Program.MutexName, out bool createdNew);
 
@@ -57,24 +61,28 @@ private static async Task HandleFileActionAsync(string[] newPaths)
 				// Waiting if more files/folders are selected
 				await Task.Delay(Program.BatchTimeoutMs);
 
-				int previousCount, nextCount = (await File.ReadAllLinesAsync(Program.TempFilePath)).Length;
+				int previousCount, nextCount = Directory.GetFiles(Program.TempFilePath).Length;
 
 				// Wait until the number stops increasing
 				do
 				{
 					previousCount = nextCount;
 					await Task.Delay(Program.BatchTimeoutMs);
-					nextCount = (await File.ReadAllLinesAsync(Program.TempFilePath)).Length;
+					nextCount = Directory.GetFiles(Program.TempFilePath).Length;
 				}
 				while (previousCount != nextCount);
 
 				List<string> allPaths = new();
 
-				// Get all paths from the temporary file
-				if (File.Exists(Program.TempFilePath))
+				// Get all paths from the temporary files
+				if (Directory.Exists(Program.TempFilePath))
 				{
-					allPaths = (await File.ReadAllLinesAsync(Program.TempFilePath)).ToList();
-					File.Delete(Program.TempFilePath);
+					foreach (var file in Directory.GetFiles(Program.TempFilePath))
+					{
+						allPaths.AddRange(await File.ReadAllLinesAsync(file));
+					}
+
+					Directory.Delete(Program.TempFilePath, true);
 				}
 
 				int count = allPaths.Count;

src/ContextMenuUploader/RegistryHelper.cs

@@ -20,10 +20,10 @@ public static void AddContextMenu(string appName, string appPath, string context
 			string regFolderPath = @"Directory\shell\" + appName;
 			RegistryHelper.CreateRegistryKey(regFolderPath, appPath, contextMenuLabel);
 
-			// Set the MultipleInvokePromptMinimum value to 256
-			RegistryHelper.SetMultipleInvokeLimit(256);
+			// Set the MultipleInvokePromptMinimum value to 512
+			RegistryHelper.SetMultipleInvokeLimit(512);
 
-			Console.WriteLine("Context menu option added for up to 256 files and folders.");
+			Console.WriteLine("Context menu option added for up to 512 files and folders.");
 		}
 		catch (Exception ex)
 		{
@@ -43,8 +43,8 @@ public static void RemoveContextMenu(string appName)
 			string regFolderPath = @"Directory\shell\" + appName;
 			Registry.ClassesRoot.DeleteSubKeyTree(regFolderPath, false);
 
-			// Reset the MultipleInvokePromptMinimum value to 15
-			RegistryHelper.SetMultipleInvokeLimit(15);
+			// Reset the MultipleInvokePromptMinimum value
+			RegistryHelper.SetMultipleInvokeLimit();
 
 			Console.WriteLine("Context menu option removed for files and folders.");
 		}
@@ -54,17 +54,27 @@ public static void RemoveContextMenu(string appName)
 		}
 	}
 
-	public static void SetMultipleInvokeLimit(int limit)
+	public static void SetMultipleInvokeLimit(int? limit = null)
 	{
 		try
 		{
 			// Open the registry key
 			using RegistryKey? key = Registry.CurrentUser.OpenSubKey(@"Software\Microsoft\Windows\CurrentVersion\Explorer", true);
 
-			// Set the "MultipleInvokePromptMinimum" value to the provided limit
-			key?.SetValue("MultipleInvokePromptMinimum", limit, RegistryValueKind.DWord);
+			if (limit.HasValue)
+			{
+				// Set the "MultipleInvokePromptMinimum" value to the provided limit
+				key?.SetValue("MultipleInvokePromptMinimum", limit, RegistryValueKind.DWord);
 
-			Console.WriteLine($"Successfully set MultipleInvokePromptMinimum to {limit}");
+				Console.WriteLine($"Successfully set MultipleInvokePromptMinimum to {limit}");
+			}
+			else
+			{
+				// Reset the "MultipleInvokePromptMinimum"
+				key?.DeleteValue("MultipleInvokePromptMinimum");
+
+				Console.WriteLine($"Successfully reset MultipleInvokePromptMinimum");
+			}
 		}
 		catch (Exception ex)
 		{