Test cleanup

[Nyholm]

This is a PR containing a few minor things:

• Let you be able to run phpunit command in root by adding in phpunit.xml
• Renamed phpunit.xml to phpunit.xml.dist because phpunit.xml is reserved for developer specific config (it will override phpunit.xml.dist)
• Moved post-install-cmd to a separate file (and made sure it works)
• Removed the boostrap file for tests. We should use composer's autoload directly
• Removed the ClassUtils because it had some bugs. Only some were fixed in Remove dependency form Guzzle #131.
• Moved tests to "autoload-dev" in composer.

The ClassUtils class made me think that the same functionality should be reused in other packages. I created a package and made sure to add tests and some more features (like supporting inheritance). The API is also a bit cleaner than the old ClassUtils

[Nyholm]

I did also remove composer.lock since it had trouble installing PHPUnit on different php versions (We want to support more versions than phpunit 5.x does.)

This PR is ready for review

[Nyholm]

Ping @avrahamgoldman

[avigoldman]

Hey @Nyholm! Sorry for the delayed response here. I'm going to review this PR this upcoming Monday 👍

[Nyholm]

Thank you!

[Nyholm]

Any updates?

[Nyholm]

Could I help you to review this in any way?

[colestrode]

let's keep composer.lock in version control

[Nyholm]

I removed composer lock because it caused issues with phpunit and different Php versions. See https://travis-ci.org/SparkPost/php-sparkpost/builds/151201635

[colestrode]

gotcha... It looks like it's just failing for 5.5. We follow the PHP supported versions (http://php.net/supported-versions.php) and 5.5 is EOL. Let's just drop the 5.5 req from travis.yml, that should mean we can keep the lock file.

[Nyholm]

Cool. I very much agree with dropping 5.5 =)

[colestrode]

Hey Nyholm, thanks for the PR :) I'm going to start looking at this today.

Would you mind sharing what bugs you found in ClassUtils that NSA fixes?

[colestrode]

nice, this is much cleaner

[Nyholm]

Thank you for taking time to review this.

Except for the bug fixes I found and fixed in #131, there were the following issues with ClassUtils:

• You could not get a property of a parent class
• It was not stateless, ie you needed a new instance of ClassUtils for each class you wanted to use it for
• No support for static methods or properties
• You could not give a method any arguments
• No argument validation
• You got strange exceptions if you tried to get a non-existent property or method.

[colestrode]

awesome, thanks for the run down. I'm taking off for the day but will come back to this in the morning.

[Nyholm]

Thank you!

[colestrode]

this is the same lib, right? just moved under a different org?

[Nyholm]

Yes, that is correct.

[colestrode]

I'm just going to make sure I can run all the tests locally, but this is looking great so far 👍

[colestrode]

Worked like a charm! Great PR @Nyholm :) I'll merge this in now.

Btw, if you can't get enough of PHP+Sparkpost, feel free to join us in our community Slack at slack.sparkpost.com :)

[Nyholm]

Awesome. Thank you for merging!