Skip to content

Commit 5c89184

Browse files
authored
Duplicate issues in quick open picker
1 parent a03ae22 commit 5c89184

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/issues/issueCompletionProvider.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export class IssueCompletionProvider implements vscode.CompletionItemProvider {
4646

4747
await this.stateManager.tryInitializeAndWait();
4848

49-
const completionItems: vscode.CompletionItem[] = [];
49+
const completionItems: Map<string, vscode.CompletionItem> = new Map();
5050
const now = new Date();
5151
let repo: PullRequestDefaults | undefined;
5252
try {
@@ -63,18 +63,18 @@ export class IssueCompletionProvider implements vscode.CompletionItemProvider {
6363
if (issuesOrMilestones[0] instanceof IssueModel) {
6464
let index = 0;
6565
for (const issue of issuesOrMilestones) {
66-
completionItems.push(await this.completionItemFromIssue(repo, <IssueModel>issue, now, range, document, index++));
66+
completionItems.set(getIssueNumberLabel(<IssueModel>issue), await this.completionItemFromIssue(repo, <IssueModel>issue, now, range, document, index++));
6767
}
6868
} else {
6969
for (let index = 0; index < issuesOrMilestones.length; index++) {
7070
const value: MilestoneModel = <MilestoneModel>issuesOrMilestones[index];
7171
for (const issue of value.issues) {
72-
completionItems.push(await this.completionItemFromIssue(repo, issue, now, range, document, index, value.milestone));
72+
completionItems.set(getIssueNumberLabel(issue), await this.completionItemFromIssue(repo, issue, now, range, document, index, value.milestone));
7373
}
7474
}
7575
}
7676
}
77-
return completionItems;
77+
return [...completionItems.values()];
7878
}
7979

8080
private async completionItemFromIssue(repo: PullRequestDefaults | undefined, issue: IssueModel, now: Date, range: vscode.Range, document: vscode.TextDocument, index: number, milestone?: IMilestone): Promise<IssueCompletionItem> {

0 commit comments

Comments
 (0)