Replace tracking with publish checks #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
...
The CLI tool currently checks for a widget.yml file containing a UUID. It then uses this UUID to perform a PUT or POST request depending on if it already exists or is new. We work with multiple environments and stores (staging, production, QA, trade/wholesale) and deploy through CI, meaning these IDs will either be wrong or the file will not exist. Removing the need to manage these files and relying on checks before publishing will simplify this process and eliminate any unnecessary complexity required with wrapper scripts. It also works better for developments running local deployments to test stores.
We have already diverged from bigcommerce/widget-builder, with the activity in the master repo being sparse. With that in mind, I haven't made this change compatible.