Correct validate command options #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgerulaitis
approved these changes
Apr 6, 2022
darrenbelding
force-pushed
the
fix-validate-command-options
branch
from
8ae9727 to
5b4aff4
Compare
tgerulaitis
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
The current options are incorrect and therefore validate commands do not run. Note: These currently need to be run inside the working directory of a widget and cannot be run in a parent directory. Running this command in a parent directory results in a generic error: "There was a problem loading the schema_translation.json file."
Testing / Proof
Validate has been run with both schema and queryParams options on their associated files, with valid and invalid JSON, as specified by their corresponding schemas.