Gui #22
Gui #22
Conversation
|
Can we move all the data files into some centralized location? right now, they're already in DataProcessing/data, |
|
Ok I updated .gitignore and deleted the data folder. As long as the user has the data, they can just navigate to it themselves. |
|
probably some combination of |
There was a problem hiding this comment.
Okay so I took a look and spent some time also trying to run some data analysis. All in all, it's looking pretty good, and a lot of the comments I left are regarding fairly minor error handling or verification of input.
One larger change that I think would be useful would be if you can save after you've gone through the process of removing, adding, and editing lines. Right now, if I go through all that effort for a tank, then do so for an injector, if I want to go back to the tank then I'd have to start the whole process overall again. It could be as simple as just saving the final positions of the lines, and having a selection box that fills up with the ones that you've already done, so at the very least you can view them again.
Another thing would be to write the values from a calculation to a file so that they can be used for analysis, and only really need to be calculated once. You could create a txt file with the same name as the CSV and have a save button where it would just write/append the calculated values to that.
For these 2 things that I've mentioned, we should chat on slack about if they make sense/specifics, so when you get a chance reach out and we can schedule a quick meeting to go over details!
Overall it's looking great - really excited to soon be able to use this regularly!
No description provided.