Use Cluster Addon Stages #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschoone
force-pushed
the
refactor/modernize_scs_cluster_stacks
branch
2 times, most recently
from
f866e24 to
6ce933f
Compare
jschoone
force-pushed
the
feat/use_addon_stages
branch
2 times, most recently
from
400223d to
ba96db3
Compare
jschoone
force-pushed
the
refactor/modernize_scs_cluster_stacks
branch
2 times, most recently
from
8ab6819 to
fbf8085
Compare
jschoone
changed the title
jschoone
force-pushed
the
refactor/modernize_scs_cluster_stacks
branch
2 times, most recently
from
f610df5 to
3d34c07
Compare
jschoone
force-pushed
the
feat/use_addon_stages
branch
from
80b2c3f to
621d3eb
Compare
1 task
chess-knight
requested changes
Mar 10, 2025
jschoone
force-pushed
the
refactor/modernize_scs_cluster_stacks
branch
from
3f9366a to
fbf6fe0
Compare
jschoone
commented
Mar 10, 2025
jschoone
force-pushed
the
feat/use_addon_stages
branch
from
f6f60b5 to
ca7f3da
Compare
jschoone
force-pushed
the
feat/use_addon_stages
branch
from
ca7f3da to
b3e8dfd
Compare
The Cluster Stack Operator has the `Multi Stage Addon` feature to install addons in a specified order. This commit adds the configuration to make use of it at least in a very simple way. Signed-off-by: Jan Schoone <jan.schoone@uhurutec.com>
Signed-off-by: Nils Arnold <arnold@aov.de>
The workload_loadbalancer should configure the lb-provider used in the Workload Cluster by overwriting the values for OCCM using the addons controller of the Cluster Stack Operator. Since we create the cloud-config for the OCCM using the openstack-csp-helper we need to disable the creation of the cluster-config secret using the OCCM Helm chart. With that no change of the cloud-config using the OCCM values will be applies, so the workload_loadbalancer variable has no effect. Signed-off-by: Jan Schoone <jan.schoone@uhurutec.com>
jschoone
force-pushed
the
feat/use_addon_stages
branch
from
6821a04 to
f4c4547
Compare
jschoone
changed the title
chess-knight
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cluster Stack Operator has the
Multi Stage Addonfeature to install addons in a specified order. This commit adds the configuration to make use of it at least in a very simple way.What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please do not use "Squash and merge" here
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: