Skip to content

Remove yawol and kube-vip #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025
Merged

Conversation

jschoone
Copy link
Contributor

@jschoone jschoone commented Feb 27, 2025

What this PR does / why we need it:

According to
https://github.com/SovereignCloudStack/minutes/blob/main/container/20250221.md
yawol and kube-vip will be removed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please do not use "Squash and merge"

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@jschoone jschoone added the Container Issues or pull requests relevant for Team 2: Container Infra and Tooling label Feb 27, 2025
@jschoone jschoone requested a review from garloff February 27, 2025 12:14
@jschoone jschoone marked this pull request as draft March 3, 2025 14:58
@jschoone jschoone force-pushed the refactor/modernize_scs_cluster_stacks branch 8 times, most recently from b28f476 to 5780439 Compare March 7, 2025 22:39
@jschoone jschoone changed the title Refactor/modernize scs cluster stacks Remove yawol and kube-vip Mar 7, 2025
@jschoone jschoone marked this pull request as ready for review March 7, 2025 22:42
@jschoone jschoone force-pushed the refactor/modernize_scs_cluster_stacks branch from f610df5 to 3d34c07 Compare March 7, 2025 22:45
Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just few suggestions:

  • update docs
  • remove yawol from openstack-csp-helper

@jschoone jschoone requested a review from chess-knight March 10, 2025 09:18
@jschoone
Copy link
Contributor Author

Overall LGTM, just few suggestions:

  • update docs
  • remove yawol from openstack-csp-helper

Thanks, docs have been updated

jschoone and others added 3 commits March 10, 2025 12:37
According to
https://github.com/SovereignCloudStack/minutes/blob/main/container/20250221.md
yawol and kube-vip will be removed.

Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Jan Schoone <jan.schoone@uhurutec.com>
refactor(cluster-addons): Update metrics-server values

The values for the metrics server have changed and some are already
outdated.
This smaller version should to the same for this case.

Signed-off-by: Jan Schoone <jan.schoone@uhurutec.com>
@jschoone jschoone force-pushed the refactor/modernize_scs_cluster_stacks branch from 3f9366a to fbf6fe0 Compare March 10, 2025 11:38
@jschoone jschoone merged commit f3a0092 into main Mar 10, 2025
3 checks passed
@jschoone jschoone deleted the refactor/modernize_scs_cluster_stacks branch March 10, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Container Issues or pull requests relevant for Team 2: Container Infra and Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants