✨ CSPO #23
Merged
✨ CSPO #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
…Release controller (#25) Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
This ensures that all parameters and descriptions used by `gophercloud` in the release referenced are up-to-date. Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud> Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
This reverts commit b47adcf. Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
matofeder
added
do-not-merge
size/XXL
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
This reapplies the change in an updated form. This reverts commit e0ca13f. Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
* Add README Signed-off-by: Matej Feder <matej.feder@dnation.cloud> * Update osnir logic Signed-off-by: Matej Feder <matej.feder@dnation.cloud> * Fix osnir logic Update OpenStackNodeImageRelease after setting owner references Signed-off-by: Roman Hros <roman.hros@dnation.cloud> --------- Signed-off-by: Matej Feder <matej.feder@dnation.cloud> Signed-off-by: Roman Hros <roman.hros@dnation.cloud> Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
matofeder
requested review from
kranurag7,
jschoone,
NotTheEvilOne and
janiskemper
cluster-stack-bot
bot
added
area/hack
matofeder
removed
the
work in progress
janiskemper
requested changes
Jan 11, 2024
Co-authored-by: janiskemper <63146658+janiskemper@users.noreply.github.com> Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
3 tasks
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
An infinite loop may occur on certain misconfigurations, e.g., if the Github/OpenStack client is misconfigured. In such cases, the operator correctly sets a condition that can be used for the user to debug. However, it also returns an error, which means that the operator reconciles immediately again. There is no need to return the error, as the user checks the conditions stored in the status of the objectrather than potential error logs. The controller's default syncPeriod, set to 5 minutes, ensures that the controller will try again later to check whether the failed state has been resolved. See related SovereignCloudStack/cluster-stack-operator#50 Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Also, modify requeue logic for download assets from github Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Hi @janiskemper, Thank you for all your valuable comments! All of them have been resolved. Could we go ahead and get your approval? Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements the initial working version of ClusterStack provider OpenStack controllers and related components.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes SovereignCloudStack/issues#506
Special notes for your reviewer:
Note that this PR should contain the working CSPO implementation, and you should be able to create a working Kubernetes workload cluster. Because of this, we created a highly experimental ClusterStacks that contains OpenStack manifests and should be used for PR testing.
Find the modified Quickstart Guide here.
This modified Quickstart Guide employs experimental Cluster Stacks and guides you to create a working K8s cluster utilizing CSPO implemented by this PR.
TODOs:
Certainly, there are some TODOs. Some of them are mentioned in the code, and the rest we list here: