Fix building with node 10.0.0 by Paxa · Pull Request #71 · Southern/node-x509

Paxa · 2018-07-07T18:29:18Z

I found this useful patch in #68 (i'm not an author of this changes)

stormwin · 2018-07-08T17:26:13Z

If i have more free time, i will fix backward incompatibilities with older nodejs versions. The problem is with OpenSSL version that is changed from 1.0.x to 1.1.x in nodeJS v10.x

stormwin · 2018-07-08T21:42:08Z

OK, finally it work on every nodejs version.

Paxa · 2018-07-09T05:10:56Z

Bravo!

jacobpdq · 2018-07-14T12:07:44Z

@Southern bump plz (needed for node-solid)

alexanderkhivrych · 2018-07-19T14:38:30Z

plz merge it

alexanderkhivrych · 2018-07-19T14:38:36Z

ASAP

alexanderkhivrych · 2018-07-19T14:38:56Z

build already green

alexanderkhivrych · 2018-07-19T14:39:20Z

@stormwin

stormwin · 2018-07-19T19:16:03Z

I am also waiting for this merge. Till then, i am using my own fork in my projects

jacobpdq · 2018-07-19T21:20:51Z

Bump

…

On Thu, Jul 19, 2018, 3:16 PM Vlado Velichkovski ***@***.***> wrote: I am also waiting for this merge. Till then, i am using my own fork in my projects — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#71 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKBbE7w5wNheCYxJcbCNeN-Z_60dYH2ks5uINr0gaJpZM4VGc1-> .

alexanderkhivrych · 2018-07-23T07:46:00Z

@Southern

Paxa · 2018-07-23T07:49:49Z

Guys, you can just use it from github: yarn add stormwin/node-x509 or npm i stormwin/node-x509

yorkie · 2018-07-28T08:51:56Z

@Paxa Thanks for this patch very much, may I ask you not to change the coding style, such that we could merge them only with building patch :)

Paxa · 2018-07-28T10:36:14Z

@yorkie I just created a PR from @stormwin fork

eduardocruz · 2018-09-17T16:22:52Z

Did the project die?

adamhamlin · 2018-11-01T20:03:04Z

Bump

mbwhite · 2018-11-16T15:53:24Z

Can this be merged please?

yorkie

@Paxa Thanks, but I found you changed the indent to a tab or 4 spaces which could make the source is hard to review, please remove those coding style changes.

yorkie · 2018-11-17T10:32:44Z

include/x509.h

-Local<Value> try_parse(const std::string& dataString);
-Local<Value> verify(const std::string& dataString);
+Local<Value> try_parse(const std::string &dataString);
+Local<Value> verify(const std::string &dataString);


Could you please revert these style changes?

i wish someone just edited these files using github inline edit :)

yorkie · 2018-11-17T10:32:53Z

include/x509.h

-char* real_name(char *data);
-char* trim(char *data, int len);
+char *real_name(char *data);
+char *trim(char *data, int len);


yorkie · 2018-11-17T10:33:30Z

src/addon.cc

+             Nan::New<FunctionTemplate>(get_issuer)->GetFunction());
+    Nan::Set(exports, Nan::New<String>("parseCert").ToLocalChecked(),
+             Nan::New<FunctionTemplate>(parse_cert)->GetFunction());
 }


Please use the 2 spaces as indents.

yorkie · 2018-11-17T10:37:13Z

Can this be merged please?

@mbwhite Sorry for the late, already leave comments here though the CI is pass :)

stormwin · 2018-11-17T14:10:15Z

OK, i will try to fix this styling stuffs and also will try to fix some warnings for node v11. Will do a new commits today or tomorrow

ghost · 2018-11-23T13:26:43Z

@stormwin you awesome!
thanks for fixing this,
hoping to see it merged

okonon · 2018-11-30T02:59:53Z

Bump. @stormwin any chance that you fixed that styling ?

This is the #71 but with corrected formatting as per the discussion in #71 Thank you to those who worked on fix; aim here is to get the fix merged as it is needed by many projects Signed-off-by: Matthew B. White <whitemat@uk.ibm.com>

okonon · 2019-01-11T19:28:34Z

Anyone can resolve the conflicts?

prompt-bot · 2019-03-14T15:43:36Z

there any follow up?

mbwhite · 2019-03-17T21:20:47Z

there any follow up?

We would have preferred to use this repo - but due to schedules we had to fork and republished to npm.

stormwin added 6 commits June 16, 2018 20:40

Update package.json

79f33dd

Update x509.cc

54ef6b6

Update x509.cc

a8e5ba0

Update x509.cc

8c4007c

Update x509.cc

1844ec1

Update x509.cc

dc48bf0

stormwin and others added 8 commits July 8, 2018 20:33

Update .travis.yml

70c52de

Fixed some of incompatibilities between nodejs versions

c6e57d2

one more (nan) fix for older nodejs versions

af15d6c

OPENSSL fixes for compatibility

07c6f0c

Fix incompatibilities with nodejs v0.x

6407b83

Fix incompatibilities with nodejs v0.x

f71920e

Final fixes

c76789c

Final fix

9f3bdd1

yorkie mentioned this pull request Jul 28, 2018

implement verifyFromStr #63

Open

change coding style to "{ BasedOnStyle: Google, IndentWidth: 4 }"

4014005

yorkie requested changes Nov 17, 2018

View reviewed changes

okonon mentioned this pull request Nov 30, 2018

x509 fails to compile with Xcode 10.1 #73

Open

mbwhite mentioned this pull request Dec 19, 2018

Fix incorrect extension handling #75

Open

Conversation

Paxa commented Jul 7, 2018

Uh oh!

stormwin commented Jul 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stormwin commented Jul 8, 2018

Uh oh!

Paxa commented Jul 9, 2018

Uh oh!

jacobpdq commented Jul 14, 2018

Uh oh!

alexanderkhivrych commented Jul 19, 2018

Uh oh!

alexanderkhivrych commented Jul 19, 2018

Uh oh!

alexanderkhivrych commented Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexanderkhivrych commented Jul 19, 2018

Uh oh!

stormwin commented Jul 19, 2018

Uh oh!

jacobpdq commented Jul 19, 2018 via email

Uh oh!

alexanderkhivrych commented Jul 23, 2018

Uh oh!

Paxa commented Jul 23, 2018

Uh oh!

yorkie commented Jul 28, 2018

Uh oh!

Paxa commented Jul 28, 2018

Uh oh!

eduardocruz commented Sep 17, 2018

Uh oh!

adamhamlin commented Nov 1, 2018

Uh oh!

mbwhite commented Nov 16, 2018

Uh oh!

yorkie left a comment

Choose a reason for hiding this comment

Uh oh!

yorkie Nov 17, 2018

Choose a reason for hiding this comment

Uh oh!

okonon Nov 30, 2018

Choose a reason for hiding this comment

Uh oh!

yorkie Nov 17, 2018

Choose a reason for hiding this comment

Uh oh!

yorkie Nov 17, 2018

Choose a reason for hiding this comment

Uh oh!

yorkie commented Nov 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stormwin commented Nov 17, 2018

Uh oh!

ghost commented Nov 23, 2018

Uh oh!

okonon commented Nov 30, 2018

Uh oh!

okonon commented Jan 11, 2019

Uh oh!

prompt-bot commented Mar 14, 2019

Uh oh!

mbwhite commented Mar 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

stormwin commented Jul 8, 2018 •

edited

Loading

alexanderkhivrych commented Jul 19, 2018 •

edited

Loading

yorkie commented Nov 17, 2018 •

edited

Loading