PrettyPrinter includes logger methods calls in stack trace on flutter web

[ciprig]

For PrettyPrinter I see logger methods calls in stacktraces. Those are not relevant:

│ #0 package:logger/src/printers/pretty_printer.dart 252:40 log
│ #1 package:logger/src/logger.dart 186:29 log

trying to add 'package:logger' in excludePaths dosen't chnage anything

Version: logger: ^2.6.1

[Bungeefan]

Hi @ciprig,
this is normal and expected as the default is to always show two lines of stack trace, even without an error:

Copied from #54:

My guess would be that you are confusing an exception stack trace with the default stack trace that is printed by PrettyPrinter's methodCount (default = 2), which is even printed when no exception was provided.
Actually, the methodCount is only used when no exception was provided.

Additionally, the output is just a stack trace (obtained via StackTrace.current) and not an exception.

EDIT:
To disable it, just set methodCount to 0.

[ciprig]

I want the stacktrace; however, I don't want that to fill up with logger calls, instead with relevant calls before the logger. The excludePaths doesn't work correctly, or it's not clear how to configure it

[Bungeefan]

Oh ok, got it, can you please provide an example that reproduces your log?
As these lines should already be filtered by default and works for me when executing the example:

logger/lib/src/printers/pretty_printer.dart

Line 321 in f5bb8ea

if (segment.startsWith('package:logger')) {

[ciprig]

final logger = Logger(
filter: null, // Use the default LogFilter (-> only log in debug mode)
printer: PrettyPrinter(
methodCount: 2, // Number of method calls to display
errorMethodCount: 8,
// Number of method calls for errors
// Exclude paths from stack traces
excludePaths: [
'package:logger',
'package:riverpod',
'package:flutter_riverpod',
'package:flutter',
'package:cloud_firestore_web'
],
), // Use the PrettyPrinter to format and print log
output: null, // Use the default LogOutput (-> send everything to console)
);

Maybe because is flutter web?

[Bungeefan]

Hi @ciprig,
thanks for your report, I was able to reproduce it via Flutter web and decided to research it a bit, before deciding on a fix.

In case you (or future readers) are interested:
Initially, there was a check in logger designed to filter Dart web stack trace lines, as can be seen here:
https://github.com/simc/logger/pull/52/files#diff-80939a007f0eb5a014f3aa9142271612fdf022c69bbaaf8fe420ec9855614ecfR260

Unfortunately, while incorporating this PR in the codebase (02ea20c) the check was mangled and never worked (I checked as far back as Dart 2.17 with logger 0.9.3).
It seems that Dart web was/is such a niche use case with logger, that nobody noticed/reported it until now.

Now, you are probably thinking, "what does this have to do with Flutter web?".
It turns out that the way Flutter web displayed stack traces (packages/logger instead of package:logger) was probably unintended and now considered a bug (a simple mapping was missing and therefore the paths from the stack trace couldn't be resolved like in Dart web).
This was fixed with the release of Flutter 3.32.0 (flutter/flutter#160383) and since then, the stack traces are different and now align with the original Dart web lines (where the check was broken since the beginning), resulting in the lines showing up only now.

TL;DR: Flutter fixed in version 3.32.0 the display of web stack traces and with it triggered an old bug in the logger code.

---

I pushed a fix for this and will soon release a new version on pub.dev!
Sorry for the misunderstanding at the beginning!