Minor performance improvement sorting directories

Dimitri van Heesch · Dimitri van Heesch · commit 67827956351f · 2016-01-31T14:09:03.000+01:00
diff --git a/src/dirdef.cpp b/src/dirdef.cpp
@@ -620,8 +620,9 @@ bool DirDef::depGraphIsTrivial() const
 int FilePairDict::compareValues(const FilePair *left,const FilePair *right) const
 {
   int orderHi = qstricmp(left->source()->name(),right->source()->name());
+  if (orderHi!=0) return orderHi;
   int orderLo = qstricmp(left->destination()->name(),right->destination()->name());
-  return orderHi==0 ? orderLo : orderHi;
+  return orderLo;
 }
 
 //----------------------------------------------------------------------

Original file line number	Diff line number	Diff line change
`@@ -620,8 +620,9 @@ bool DirDef::depGraphIsTrivial() const`
`620`	`620`	`int FilePairDict::compareValues(const FilePair left,const FilePair right) const`
`621`	`621`	`{`
`622`	`622`	`int orderHi = qstricmp(left->source()->name(),right->source()->name());`
	`623`	`+ if (orderHi!=0) return orderHi;`
`623`	`624`	`int orderLo = qstricmp(left->destination()->name(),right->destination()->name());`
`624`		`- return orderHi==0 ? orderLo : orderHi;`
	`625`	`+ return orderLo;`
`625`	`626`	`}`
`626`	`627`
`627`	`628`	`//----------------------------------------------------------------------`