Correctly determine if element should be moved or cloned #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good Job on the PR! it looks ok tbh, would it be too hard to add an |
|
Will do |
|
Any chance this can be merged soon? I'm running in to this issue as well and looking for a fix. |
samjacobclift
approved these changes
Nov 7, 2017
|
deployed new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #34
It seems that
evt.cloneis always defined for onAdd events. This PR changes the logic to checkSortable.active.lastPullMode === 'clone'which I believe is the most reliable way to determine if the add was a clone or simply a move.