Fixed handling of validation errors

GrahamCampbell · GrahamCampbell · commit 1a4225096a92 · 2019-11-05T18:21:52.000Z
diff --git a/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php b/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php
@@ -76,13 +76,18 @@ public function doHandleRequest(RequestInterface $request, callable $next, calla
                                 break;
 
                             default:
-                                $errors[] = $error['message'];
+                                if (isset($error['message'])) {
+                                    $errors[] = $error['message'];
+                                }
                                 break;
 
                         }
                     }
 
-                    throw new ValidationFailedException('Validation Failed: '.implode(', ', $errors), 422);
+                    throw new ValidationFailedException(
+                        $errors ? 'Validation Failed: '.implode(', ', $errors) : 'Validation Failed',
+                        422
+                    );
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -76,13 +76,18 @@ public function doHandleRequest(RequestInterface $request, callable $next, calla`
`76`	`76`	`break;`
`77`	`77`
`78`	`78`	`default:`
`79`		`- $errors[] = $error['message'];`
	`79`	`+ if (isset($error['message'])) {`
	`80`	`+ $errors[] = $error['message'];`
	`81`	`+ }`
`80`	`82`	`break;`
`81`	`83`
`82`	`84`	`}`
`83`	`85`	`}`
`84`	`86`
`85`		`- throw new ValidationFailedException('Validation Failed: '.implode(', ', $errors), 422);`
	`87`	`+ throw new ValidationFailedException(`
	`88`	`+ $errors ? 'Validation Failed: '.implode(', ', $errors) : 'Validation Failed',`
	`89`	`+ 422`
	`90`	`+ );`
`86`	`91`	`}`
`87`	`92`	`}`
`88`	`93`