Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Latest commit

 

History

History
52 lines (38 loc) · 4.01 KB

CONTRIBUTING.md

File metadata and controls

52 lines (38 loc) · 4.01 KB
Raw

Table of Contents

  1. Contributing to Tyk
  2. Our SLA for issues and bugs
  3. Filling an issue
  4. Contributor License Agreements
  5. Guidelines for Pull Requests
  6. Project Structure
  7. Building and Running test
  8. Coding Conventions
  9. Resources

Contributing to Tyk

First: if you're unsure or afraid of anything, just ask or submit the issue or pull request anyway. You won't be yelled at for giving your best effort. The worst that can happen is that you'll be politely asked to change something. We appreciate any sort of contributions, and don't want a wall of rules to get in the way of that.

However, for those individuals who want a bit more guidance on the best way to contribute to the project, read on. This document will cover what we're looking for. By addressing all the points we're looking for, it raises the chances we can quickly merge or address your contributions.

Our SLA for issues and bugs

We do value the time each contributor spends contributing to this repo, and we work hard to make sure we respond to your issues and pull request as soon as we can.

Filling an issue

Before opening an issue, if you have a question about Tyk or have a problem using it, please start with the GitHub search and our community forum. If that doesn't answer your questions, and you have an idea for a new capability or if you think you found a bug, file an issue.

Contributor License Agreements

Before we can accept any PR the contributor need to sign the TYK CLA.

Once you are CLA'ed, we'll be able to accept your pull requests.For any issues that you face during this process, please create a GitHub issue explaining the problem, and we will help get it sorted out.

Guidelines for Pull Requests

We have created a few guidelines to help with creating PR. To make sure these requirements are followed we added them to the PR form as well:

  1. When working on an existing issue, simply respond to the issue and express interest in working on it. This helps other people know that the issue is active, and hopefully prevents duplicated efforts.
  2. For new ideas or breaking changes it is always better to open an issue and discuss your idea with our team first, before implementing it.
  3. Create small Pull request that address a single issue instead of multiple issues at the same time. This will make it possible for the PRs to be reviewed independently.
  4. Make sure to run tests locally before submitting a pull request and verify that all of them are passing.
  5. Documentation - a new capability or improvement needs to be exposed in the form of documentation which needs to be created before this PR is merged. Please open a ticket in Tyk docs repo with all the relevant content and link it to the code PR. We are also happy work with you on creating docs so please let us know. Once the docs are ready and review has been done we can merge the PR
  6. Tips for making sure we review your pull request faster :
    1. Code is documented. Please comment the code where possible, especially for fields and functions.
    2. Use meaningful commit messages.
    3. Keep your pull request up to date with upstream master to avoid merge conflicts.
    4. Provide a good PR description as a record of what change is being made and why it was made. Link to a GitHub issue if it exists.
    5. Tick all the relevant checkboxes in the PR form

Resources