Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract assertion method detection #9619

Open
sebastien-marichal opened this issue Aug 8, 2024 · 0 comments
Open

Extract assertion method detection #9619

sebastien-marichal opened this issue Aug 8, 2024 · 0 comments
Labels
Type: Cleanup Improve and cleanup code base

Comments

@sebastien-marichal
Copy link
Contributor

S3431 implementation now checks if an assertion is done in a catch or finally block (see here). The detection is very similar but less thorough than S2699 (TestMethodShouldContainAssertion)

This detection should be extracted so it can be reused in both rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Cleanup Improve and cleanup code base
Projects
None yet
Development

No branches or pull requests

1 participant