Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview to TypedInput #675

Open
nataly87s opened this issue Dec 6, 2017 · 0 comments
Open

Add preview to TypedInput #675

nataly87s opened this issue Dec 6, 2017 · 0 comments

Comments

@nataly87s
Copy link
Contributor

At the moment, if you have a really long value or multiline text it is not displayed well in the editor.
We should add an option to preview/edit the value in a popup.

We already have an Alerts component that we can use with redux, and wait for a result. For example in src/components/JPadFullEditor/JPadVisualEditor/JPadVisualEditor.js the handlePartitionAddition function (starting line 58)

  const handlePartitionAddition = async (newPartition) => {
    // some code
    const alertResult = (await alerter.showCustomAlert(autoPartitionAlert(testAutoPartition)))
      .result;

    switch (alertResult) {
    case 'RESET':
      // do stuff
      break;
    case 'OK':
      // do other stuff
      break;
    }
  };
@nataly87s nataly87s changed the title add preview to TypedInput Add preview to TypedInput Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant