feat: Added a namespace to the auto-generated concrete classes

SolidAlloy · SolidAlloy · commit 73af6e8a00cb · 2022-01-24T18:11:58.000+02:00
This is done so that they are grouped and hidden in the type reference dropdown
diff --git a/Editor/AssemblyCreator/AssemblyCreatorHelper.cs b/Editor/AssemblyCreator/AssemblyCreatorHelper.cs
@@ -162,7 +162,7 @@ public ConcreteClassAssembly(string dirPath, string assemblyName, string classNa
 
                 _assemblyBuilder = GetAssemblyBuilder(dirPath, assemblyName);
                 ModuleBuilder moduleBuilder = GetModuleBuilder(_assemblyBuilder, assemblyName);
-                TypeBuilder = moduleBuilder.DefineType(className, TypeAttributes.NotPublic, parentType);
+                TypeBuilder = moduleBuilder.DefineType($"GenericUnityObjects.ConcreteClasses.{className}", TypeAttributes.NotPublic, parentType);
             }
 
             public void Dispose()
diff --git a/Editor/ScriptableObjects/SelectionWindow/OneTypeSelectionWindow.cs b/Editor/ScriptableObjects/SelectionWindow/OneTypeSelectionWindow.cs
@@ -1,6 +1,7 @@
 ﻿namespace GenericUnityObjects.Editor.ScriptableObjects.SelectionWindow
 {
     using System;
+    using System.Linq;
     using TypeReferences.Editor.Drawers;
     using UnityDropdown.Editor;
     using Util;
@@ -23,7 +24,7 @@ public void OnCreate(Action<Type[]> onTypeSelected, string[] genericArgNames, Ty
         private DropdownMenu GetDropdownTree(NonGenericAttribute attribute, Action<Type[]> onTypeSelected)
         {
             var parentDrawer = new TypeDropdownDrawer(null, attribute, null);
-            var dropdownItems = parentDrawer.GetDropdownItems();
+            var dropdownItems = parentDrawer.GetDropdownItems().ToList();
 
             var dropdownMenu = new DropdownMenu<Type>(dropdownItems, type =>
                 {

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ public ConcreteClassAssembly(string dirPath, string assemblyName, string classNa`
`162`	`162`
`163`	`163`	`_assemblyBuilder = GetAssemblyBuilder(dirPath, assemblyName);`
`164`	`164`	`ModuleBuilder moduleBuilder = GetModuleBuilder(_assemblyBuilder, assemblyName);`
`165`		`- TypeBuilder = moduleBuilder.DefineType(className, TypeAttributes.NotPublic, parentType);`
	`165`	`+ TypeBuilder = moduleBuilder.DefineType($"GenericUnityObjects.ConcreteClasses.{className}", TypeAttributes.NotPublic, parentType);`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`public void Dispose()`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`namespace GenericUnityObjects.Editor.ScriptableObjects.SelectionWindow`
`2`	`2`	`{`
`3`	`3`	`using System;`
	`4`	`+ using System.Linq;`
`4`	`5`	`using TypeReferences.Editor.Drawers;`
`5`	`6`	`using UnityDropdown.Editor;`
`6`	`7`	`using Util;`
`@@ -23,7 +24,7 @@ public void OnCreate(Action<Type[]> onTypeSelected, string[] genericArgNames, Ty`
`23`	`24`	`private DropdownMenu GetDropdownTree(NonGenericAttribute attribute, Action<Type[]> onTypeSelected)`
`24`	`25`	`{`
`25`	`26`	`var parentDrawer = new TypeDropdownDrawer(null, attribute, null);`
`26`		`- var dropdownItems = parentDrawer.GetDropdownItems();`
	`27`	`+ var dropdownItems = parentDrawer.GetDropdownItems().ToList();`
`27`	`28`
`28`	`29`	`var dropdownMenu = new DropdownMenu<Type>(dropdownItems, type =>`
`29`	`30`	`{`