Skip to content

Conversation

@jamiecarter7
Copy link
Contributor

@jamiecarter7 jamiecarter7 commented Jan 26, 2019

What:
Missing end statement ;
Correction of $url -> $uri

Why:
Currently they throw an error.

How:

  • I am working based off of develop
  • I have rebased my PR off of develop

Missing end statement ;
Correction of $url -> $uri
@SolarLiner
Copy link
Owner

Oh, nice catch!

@SolarLiner SolarLiner merged commit 140e1b0 into SolarLiner:develop Feb 8, 2019
SolarLiner added a commit that referenced this pull request Jul 25, 2019
* Fix to nginx statement (#22)

Missing end statement ;
Correction of $url -> $uri

* Update tag to reflect 1.1.4 release

* Fix typo in README

* Bump version in README badge

* Provide workaround for global installs in Puppeteer image

The NPM prefix needs to be set somewhere with write access for global packages, which the image doesn't set for the default prefix.

* Added information about customRendererConfig (#26)

* Fixes error if there's no pluginOptions.prerenderSpa in vue.config.js (#35)

* Bump lodash from 4.17.10 to 4.17.15

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.15.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.10...4.17.15)

Signed-off-by: dependabot[bot] <support@github.com>

* Bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants