Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Error: External & Internal Type #353

Open
OEG-Clark opened this issue Jun 27, 2022 · 6 comments
Open

Dependency Error: External & Internal Type #353

OEG-Clark opened this issue Jun 27, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@OEG-Clark
Copy link
Contributor

file_module = abs_repo_path + "/" + m + "/" + i + ".py"

Should change this line into: file_module = abs_repo_path + "/" + m + ".py"

@OEG-Clark
Copy link
Contributor Author

I cannot upload a json file here, but the code is, as you can see, the import from pipetools should be considered as internal, but in the image below labelled as external. Since I think the definition of external/internal should be in the scale of the repo/project.

image

@OEG-Clark
Copy link
Contributor Author

And I have printed the path in the code reference above, if it ends with i.py is a function name as a python file.

@dgarijo
Copy link
Collaborator

dgarijo commented Jul 4, 2022

Just FYI, Clark, you can upload txt files if you change the json extension to txt

@OEG-Clark
Copy link
Contributor Author

@dgarijo dgarijo added the bug Something isn't working label Jul 7, 2022
@dgarijo
Copy link
Collaborator

dgarijo commented Jul 7, 2022

Some additional tests need to be added here

@rosafilgueira
Copy link
Collaborator

rosafilgueira commented Jul 14, 2022

I had a bit of time today, and I think I have solved the problem with the dependencies. It is not 100% garentee ... since more test would be needed, but it seems that my changes, solve the problems found by @OEG-Clark for piptools repo.

See bellow:

Screenshot 2022-07-14 at 14 26 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants