Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perimeters offset too much for one wall on top surfaces #3313

Closed
vovodroid opened this issue Dec 27, 2023 · 4 comments · Fixed by #6236
Closed

Perimeters offset too much for one wall on top surfaces #3313

vovodroid opened this issue Dec 27, 2023 · 4 comments · Fixed by #6236
Labels

Comments

@vovodroid
Copy link
Contributor

For lower top surfaces perimeters are shifted inward, especially when there are number of walls:

image

I guess instead of complex calculations here

coord_t offset_top_surface =

something like coord_t offset_top_surface = ext_perimeter_width; could produce better result:

image

providing base for next layer external perimeter. Picture is from Prusa with ported code.

Orca-Cube.zip

@Eldenroot
Copy link
Contributor

Are you working on a PR?

@vovodroid
Copy link
Contributor Author

Not really. Merill took this code to his SS and used some other formula - supermerill/SuperSlicer#4022 (comment)

Copy link

Orca bot: this issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale label Mar 29, 2024
Copy link

github-actions bot commented Apr 5, 2024

Orca bot: This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants