Skip to content

Fix exit code from returning 5 on diff reports with no error alerts a… #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

dacoburn
Copy link
Collaborator

…nd only warn

Root Cause

Logic was incorrectly added to have the CLI exit with error code 5 if there were only warn alerts in the diff report. This was not the intended behavior.

Fix

Removed this incorrect logic

Public Changelog

  • Updated the CLI to return 0 for the exit code if the only alerts in the diff report are warn alerts instead of incorrectly returning 5

@dacoburn dacoburn requested a review from a team as a code owner June 30, 2025 18:17
@dacoburn dacoburn requested review from amoeller and jfblaa and removed request for a team June 30, 2025 18:17
@dacoburn dacoburn added the Product Changelog New features for the public changelog label Jun 30, 2025
Copy link

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.1.19.dev1

Docker image: socketdev/cli:pr-99

@dacoburn dacoburn merged commit 1717d0a into main Jun 30, 2025
6 checks passed
@dacoburn dacoburn deleted the doug/fix-exit-code-on-warn branch June 30, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product Changelog New features for the public changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants