Skip to content

Doug/fix skip logic #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

Doug/fix skip logic #95

merged 3 commits into from
Jun 30, 2025

Conversation

dacoburn
Copy link
Collaborator

Root Cause

Logic could fail if Manifest files were none for the direct dependencies. Also, the logic for the license generation could run even if no diff scan ran

Fix

Added a gate for manifest files and fixed logic for generate license

Public Changelog

N/A

@dacoburn dacoburn requested a review from a team as a code owner June 30, 2025 14:33
@dacoburn dacoburn requested review from tmpvar and bmeck and removed request for a team June 30, 2025 14:33
Copy link

github-actions bot commented Jun 30, 2025

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.1.16.dev2

Docker image: socketdev/cli:pr-95

@dacoburn dacoburn merged commit 31003ad into main Jun 30, 2025
6 checks passed
@dacoburn dacoburn deleted the doug/fix-skip-logic branch June 30, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants