Skip to content

Added 'api' event type to Gitlab and added new option --license-file-… #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025

Conversation

dacoburn
Copy link
Collaborator

@dacoburn dacoburn commented Jul 3, 2025

…name that defaults to license_output.json instead of a dynamic name that could be a bad filename

Root Cause

The file name that was being generated from the repo and branch was not being serialized to a safe file name that could cause the code to error.

The api event type for gitlab wasn't supported which would cause the CLI to error.

Fix

  1. Added the api event type to the gitlab logic.
  2. Added a new param --license-file-name to use for the license file and defaults to license_output.json

Public Changelog

  • Added support for the api event type for Gitlab
  • Added a new parameter --license-file-name instead of trying to generate the file name from the repo and branch for a safer license file name.

…name that defaults to license_output.json instead of a dynamic name that could be a bad filename
@dacoburn dacoburn requested a review from a team as a code owner July 3, 2025 05:00
@dacoburn dacoburn requested review from nolanlawson and cenobitedk and removed request for a team July 3, 2025 05:00
@dacoburn dacoburn added the Product Changelog New features for the public changelog label Jul 3, 2025
Copy link

github-actions bot commented Jul 3, 2025

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.1.21.dev1

Docker image: socketdev/cli:pr-100

Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedurllib3@​2.3.0 ⏵ 2.5.097 +1100100100100

View full report

@socket-security-staging
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedurllib3@​2.3.0 ⏵ 2.5.097 +1100100100100

View full report

@dacoburn dacoburn merged commit 9a1d030 into main Jul 3, 2025
6 checks passed
@dacoburn dacoburn deleted the doug/fix-license-file-name-and-add-gitlab-event-type branch July 3, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product Changelog New features for the public changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants