Skip to content

Commit 959e7c1

Browse files
morealyouknowone
authored andcommitted
Unmark fixed tests
1 parent 21ae739 commit 959e7c1

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

Lib/test/test_descr.py

-2
Original file line numberDiff line numberDiff line change
@@ -1052,8 +1052,6 @@ class Cdict(object):
10521052
self.assertEqual(x.foo, 1)
10531053
self.assertEqual(x.__dict__, {'foo': 1})
10541054

1055-
# TODO: RUSTPYTHON
1056-
@unittest.expectedFailure
10571055
def test_object_class_assignment_between_heaptypes_and_nonheaptypes(self):
10581056
class SubType(types.ModuleType):
10591057
a = 1

Lib/test/test_importlib/test_lazy.py

-18
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ def new_module(self, source_code=None):
7575
self.assertIsNone(loader.loaded)
7676
return module
7777

78-
# TODO: RUSTPYTHON
79-
@unittest.expectedFailure
8078
def test_e2e(self):
8179
# End-to-end test to verify the load is in fact lazy.
8280
importer = TestingImporter()
@@ -90,57 +88,43 @@ def test_e2e(self):
9088
self.assertIsNotNone(importer.loaded)
9189
self.assertEqual(module, importer.loaded)
9290

93-
# TODO: RUSTPYTHON
94-
@unittest.expectedFailure
9591
def test_attr_unchanged(self):
9692
# An attribute only mutated as a side-effect of import should not be
9793
# changed needlessly.
9894
module = self.new_module()
9995
self.assertEqual(TestingImporter.mutated_name, module.__name__)
10096

101-
# TODO: RUSTPYTHON
102-
@unittest.expectedFailure
10397
def test_new_attr(self):
10498
# A new attribute should persist.
10599
module = self.new_module()
106100
module.new_attr = 42
107101
self.assertEqual(42, module.new_attr)
108102

109-
# TODO: RUSTPYTHON
110-
@unittest.expectedFailure
111103
def test_mutated_preexisting_attr(self):
112104
# Changing an attribute that already existed on the module --
113105
# e.g. __name__ -- should persist.
114106
module = self.new_module()
115107
module.__name__ = 'bogus'
116108
self.assertEqual('bogus', module.__name__)
117109

118-
# TODO: RUSTPYTHON
119-
@unittest.expectedFailure
120110
def test_mutated_attr(self):
121111
# Changing an attribute that comes into existence after an import
122112
# should persist.
123113
module = self.new_module()
124114
module.attr = 6
125115
self.assertEqual(6, module.attr)
126116

127-
# TODO: RUSTPYTHON
128-
@unittest.expectedFailure
129117
def test_delete_eventual_attr(self):
130118
# Deleting an attribute should stay deleted.
131119
module = self.new_module()
132120
del module.attr
133121
self.assertFalse(hasattr(module, 'attr'))
134122

135-
# TODO: RUSTPYTHON
136-
@unittest.expectedFailure
137123
def test_delete_preexisting_attr(self):
138124
module = self.new_module()
139125
del module.__name__
140126
self.assertFalse(hasattr(module, '__name__'))
141127

142-
# TODO: RUSTPYTHON
143-
@unittest.expectedFailure
144128
def test_module_substitution_error(self):
145129
with test_util.uncache(TestingImporter.module_name):
146130
fresh_module = types.ModuleType(TestingImporter.module_name)
@@ -149,8 +133,6 @@ def test_module_substitution_error(self):
149133
with self.assertRaisesRegex(ValueError, "substituted"):
150134
module.__name__
151135

152-
# TODO: RUSTPYTHON
153-
@unittest.expectedFailure
154136
def test_module_already_in_sys(self):
155137
with test_util.uncache(TestingImporter.module_name):
156138
module = self.new_module()

0 commit comments

Comments
 (0)