Fix a bug where a temp rdb file with zero bytes is generated in flash mode. (#696)

karthyuom · Karthick Ariyaratnam (A) · web-flow · commit 501ae473e180 · 2023-07-13T13:26:00.000-04:00
Co-authored-by: Karthick Ariyaratnam (A) &lt;k00809413@china.huawei.com&gt;
diff --git a/src/replication.cpp b/src/replication.cpp
@@ -3732,7 +3732,7 @@ void syncWithMaster(connection *conn) {
     }
 
     /* Prepare a suitable temp file for bulk transfer */
-    if (!useDisklessLoad()) {
+    if (!useDisklessLoad() && !mi->isRocksdbSnapshotRepl) {
         while(maxtries--) {
             auto dt = std::chrono::system_clock::now().time_since_epoch();
             auto dtMillisecond = std::chrono::duration_cast<std::chrono::milliseconds>(dt);

Original file line number	Diff line number	Diff line change
`@@ -3732,7 +3732,7 @@ void syncWithMaster(connection *conn) {`
`3732`	`3732`	`}`
`3733`	`3733`
`3734`	`3734`	`/* Prepare a suitable temp file for bulk transfer */`
`3735`		`- if (!useDisklessLoad()) {`
	`3735`	`+ if (!useDisklessLoad() && !mi->isRocksdbSnapshotRepl) {`
`3736`	`3736`	`while(maxtries--) {`
`3737`	`3737`	`auto dt = std::chrono::system_clock::now().time_since_epoch();`
`3738`	`3738`	`auto dtMillisecond = std::chrono::duration_cast<std::chrono::milliseconds>(dt);`