fix(Core): ensure in memory connection is kept

Author: BrycensRanch

SnapX.Core/History/HistoryManagerSQLite.cs

@@ -37,8 +37,16 @@ UPDATE HistoryItems SET
             ShortenedURL = @ShortenedURL,
             Hidden       = @Hidden
         WHERE Id = @Id;";
-        using var connection = new SqliteConnection(Connection.ConnectionString);
-        connection.Open();
+        SqliteConnection connection = Connection;
+        bool isMemoryDb = Connection.ConnectionString.Contains(":memory:", StringComparison.OrdinalIgnoreCase) ||
+          Connection.ConnectionString.Contains("Mode=Memory", StringComparison.OrdinalIgnoreCase);
+        if (!isMemoryDb)
+        {
+            // For each Save operation, we create a new connection for concurrency. SQLite handles the connections.
+            var concurrentConnection = new SqliteConnection(Connection.ConnectionString);
+            concurrentConnection.Open();
+            connection = concurrentConnection;
+        }
 
         using var transaction = connection.BeginTransaction();
         try
@@ -58,6 +66,10 @@ UPDATE HistoryItems SET
             transaction.Rollback();
             return false;
         }
+        finally
+        {
+            if (!isMemoryDb) connection.Close();
+        }
     }
 
     [DapperAot]
@@ -97,9 +109,16 @@ UPDATE HistoryItems
     [DapperAot]
     protected override bool Append(string? filePath, IEnumerable<HistoryItem> historyItems)
     {
-        // For each Append operation, we create a new connection for concurrency. SQLite handles the connections.
-        using var connection = new SqliteConnection(Connection.ConnectionString);
-        connection.Open();
+        SqliteConnection connection = Connection;
+        bool isMemoryDb = Connection.ConnectionString.Contains(":memory:", StringComparison.OrdinalIgnoreCase) ||
+          Connection.ConnectionString.Contains("Mode=Memory", StringComparison.OrdinalIgnoreCase);
+        if (!isMemoryDb)
+        {
+            // For each Append operation, we create a new connection for concurrency. SQLite handles the connections.
+            var concurrentConnection = new SqliteConnection(Connection.ConnectionString);
+            concurrentConnection.Open();
+            connection = concurrentConnection;
+        }
         using var tx = connection.BeginTransaction();
         try
         {
@@ -194,6 +213,14 @@ INSERT INTO Tags
             tx.Rollback();
             return false;
         }
+        finally
+        {
+            if (!isMemoryDb)
+            {
+                connection?.Dispose();
+            }
+
+        }
     }
 
 }