fix(Core): ensure all custom uploader functions are registered

ShareX Custom Uploader Syntax Parser only populated the registry when given a file. This is a very bad bug that broke URL shorteners and URL sharing services (no file!)

Now, the behaavior is more consistent and quarantined in the registry itself.

Author: BrycensRanch

SnapX.Core/Upload/Custom/CustomUploaderFunctionRegistry.cs

@@ -8,7 +8,25 @@ internal static class CustomUploaderFunctionRegistry
 
     internal static IReadOnlyList<CustomUploaderFunction> Functions => _functions;
 
-    internal static void Register(CustomUploaderFunction function)
+    static CustomUploaderFunctionRegistry()
+    {
+        // Must manually do this shit wtf
+        r(new CustomUploaderFunctionBase64());
+        r(new CustomUploaderFunctionFileName());
+        r(new CustomUploaderFunctionHeader());
+        r(new CustomUploaderFunctionInput());
+        r(new CustomUploaderFunctionInputBox());
+        r(new CustomUploaderFunctionJson());
+        r(new CustomUploaderFunctionOutputBox());
+        r(new CustomUploaderFunctionRandom());
+        r(new CustomUploaderFunctionRegex());
+        r(new CustomUploaderFunctionResponse());
+        r(new CustomUploaderFunctionResponseURL());
+        r(new CustomUploaderFunctionSelect());
+        r(new CustomUploaderFunctionXml());
+    }
+
+    internal static void r(CustomUploaderFunction function)
     {
         _functions.Add(function);
     }

SnapX.Core/Upload/Custom/CustomUploaderItem.cs

@@ -41,7 +41,7 @@ protected void OnPropertyChanged(string prop) =>
     public bool ShouldSerializeName() =>
         !string.IsNullOrEmpty(Name) && Name != URLHelpers.GetHostName(RequestURL);
 
-    [JsonConverter(typeof(JsonStringEnumConverter))]
+    [JsonConverter(typeof(JsonStringEnumConverter<CustomUploaderDestinationType>))]
     [DefaultValue(CustomUploaderDestinationType.None)]
     public CustomUploaderDestinationType DestinationType
     {
@@ -94,7 +94,7 @@ public string? RequestURL
 
     public bool ShouldSerializeHeaders() => Headers is { Count: > 0 };
 
-    [JsonConverter(typeof(JsonStringEnumConverter))]
+    [JsonConverter(typeof(JsonStringEnumConverter<CustomUploaderBody>))]
     [DefaultValue(CustomUploaderBody.None)]
     public CustomUploaderBody Body { get; set; } = CustomUploaderBody.None;
 
@@ -120,7 +120,7 @@ public bool ShouldSerializeData() =>
         (Body == CustomUploaderBody.JSON || Body == CustomUploaderBody.XML)
         && !string.IsNullOrEmpty(Data);
 
-    [JsonConverter(typeof(JsonStringEnumConverter))]
+    [JsonConverter(typeof(JsonStringEnumConverter<ResponseType>))]
     // TEMP: For backward compatibility
     public ResponseType ResponseType { private get; set; }
 
@@ -260,11 +260,7 @@ public string GetContentType()
         return result;
     }
 
-    [UnconditionalSuppressMessage(
-        "Trimming",
-        "IL2026:Members annotated with 'RequiresUnreferencedCodeAttribute' require dynamic access otherwise can break functionality when trimming application code",
-        Justification = "<Pending>"
-    )]
+
     private string? EncodeBodyData(string? input)
     {
         if (!string.IsNullOrEmpty(input))

SnapX.Core/Upload/Custom/ShareXCustomUploaderSyntaxParser.cs

@@ -12,8 +12,6 @@ namespace SnapX.Core.Upload.Custom;
 
 public class ShareXCustomUploaderSyntaxParser : ShareXSyntaxParser
 {
-    private static IEnumerable<CustomUploaderFunction> Functions =>
-        CustomUploaderFunctionRegistry.Functions;
 
 
     public string? FileName { get; set; }
@@ -23,26 +21,9 @@ public class ShareXCustomUploaderSyntaxParser : ShareXSyntaxParser
     public bool UseNameParser { get; set; }
     public NameParserType NameParserType { get; set; } = NameParserType.Text;
 
-    private void r(CustomUploaderFunction func)
-    {
-        CustomUploaderFunctionRegistry.Register(func);
-    }
+
     public ShareXCustomUploaderSyntaxParser()
     {
-        // Must manually do this shit wtf
-       r(new CustomUploaderFunctionBase64());
-       r(new CustomUploaderFunctionFileName());
-       r(new CustomUploaderFunctionHeader());
-       r(new CustomUploaderFunctionInput());
-       r(new CustomUploaderFunctionInputBox());
-       r(new CustomUploaderFunctionJson());
-       r(new CustomUploaderFunctionOutputBox());
-       r(new CustomUploaderFunctionRandom());
-       r(new CustomUploaderFunctionRegex());
-       r(new CustomUploaderFunctionResponse());
-       r(new CustomUploaderFunctionResponseURL());
-       r(new CustomUploaderFunctionSelect());
-       r(new CustomUploaderFunctionXml());
     }
 
     public ShareXCustomUploaderSyntaxParser(CustomUploaderInput input)
@@ -71,7 +52,7 @@ public ShareXCustomUploaderSyntaxParser(CustomUploaderInput input)
             throw new Exception("Function name cannot be empty.");
         }
 
-        foreach (CustomUploaderFunction function in Functions)
+        foreach (CustomUploaderFunction function in CustomUploaderFunctionRegistry.Functions)
         {
             if (!function.Name.Equals(functionName, StringComparison.OrdinalIgnoreCase) &&
                 (function.Aliases == null ||

SnapX.Core/Upload/UploaderFactory.cs

@@ -116,6 +116,7 @@ static UploaderFactory()
     Register(new OneTimeSecretTextUploaderService());
     Register(new Paste2TextUploaderService());
     Register(new Paste_eeTextUploaderService());
+    Register(new PastieTextUploaderService());
     Register(new PastebinTextUploaderService());
     }
 }