Skip to content

Commit 5974b97

Browse files
committed
fix(Core): make FileExistAction.Ask non-fatal
1 parent 3715ab8 commit 5974b97

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

SnapX.Core/Job/TaskHelpers.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ public static void SaveImageAsFile(Image img, TaskSettings taskSettings, bool ov
443443
switch (taskSettings.ImageSettings.FileExistAction)
444444
{
445445
case FileExistAction.Ask:
446-
throw new NotImplementedException("FileExistAction.Ask not implemented");
446+
new NotImplementedException("FileExistAction.Ask not implemented").ShowError();
447447
break;
448448
case FileExistAction.UniqueName:
449449
filePath = FileHelpers.GetUniqueFilePath(filePath);

SnapX.Core/Utils/Extensions/Extensions.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,6 @@ public static PointF Restrict(this PointF point, RectangleF rect)
224224
public static void ShowError(this Exception e, bool fullError = true)
225225
{
226226
var error = fullError ? e.ToString() : e.Message;
227-
// TODO: Remove all calls of this function. It shows that they're still handling UI concerns.
228227
DebugHelper.WriteException(error);
229228
}
230229

0 commit comments

Comments
 (0)