Basic fixes to Infernalfarm #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed infernalfarm so it would actually work - harvest, replant nether wart.
TheBusyBiscuit
requested changes
Nov 4, 2020
Comment on lines
+64
to
+76
| @Override | ||
| public void onBlockRegistered(Location location, boolean isPlacing) { | ||
| int range = RADIUS / 2; | ||
| Block block = location.getBlock(); | ||
|
|
||
| for (int x = -range; x <= range; x++) { | ||
| for (int z = -range; z <= range; z++) { | ||
| blocks.add(block.getRelative(x, 2, z)); | ||
| } | ||
| } | ||
|
|
||
| super.onBlockRegistered(location, isPlacing); | ||
| } |
There was a problem hiding this comment.
This is just horrible and redundant, by calling the super method you add all blocks on the same y level yet again.
And this is very redundant as it only deviates from the super method by a single parameter.
There was a problem hiding this comment.
Also the build is failing too...
Fixed building issue - missed an import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed infernalfarm so it would actually work - harvest, replant nether wart.
Changes
Added a check for blocks in 5 block radius 2 blocks above the machine for nether wart and fixed harvesting not resseting the age of the plant to 0.
Related Issues
None
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values