Skip to content

Commit ca5ebd6

Browse files
committed
task2909. Рефакторинг 9
1 parent 150c57b commit ca5ebd6

File tree

4 files changed

+116
-102
lines changed

4 files changed

+116
-102
lines changed
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
package com.javarush.task.task29.task2909.human;
2+
3+
/** @author Stanislav Rakitov */
4+
public class BloodGroup {
5+
private final int code;
6+
7+
private BloodGroup(int code) {
8+
this.code = code;
9+
}
10+
11+
public static BloodGroup first() {
12+
return new BloodGroup(1);
13+
}
14+
15+
public static BloodGroup second() {
16+
return new BloodGroup(2);
17+
}
18+
19+
public static BloodGroup third() {
20+
return new BloodGroup(3);
21+
}
22+
23+
public static BloodGroup fourth() {
24+
return new BloodGroup(4);
25+
}
26+
27+
public int getCode() {
28+
return code;
29+
}
30+
}

3.JavaMultithreading/src/com/javarush/task/task29/task2909/human/Human.java

Lines changed: 74 additions & 90 deletions
Original file line numberDiff line numberDiff line change
@@ -4,93 +4,77 @@
44
import java.util.Collections;
55
import java.util.List;
66

7-
public class Human implements Alive{
8-
private static int nextId = 0;
9-
private int id;
10-
protected int age;
11-
protected String name;
12-
13-
protected int[] size;
14-
15-
public static final int FIRST = 1;
16-
public static final int SECOND = 2;
17-
public static final int THIRD = 3;
18-
public static final int FOURTH = 4;
19-
private int bloodGroup;
20-
private List<Human> children = new ArrayList<>();
21-
22-
public void setBloodGroup(int code) {
23-
bloodGroup = code;
24-
}
25-
26-
public int getBloodGroup() {
27-
return bloodGroup;
28-
}
29-
30-
// public Human(boolean isSoldier) {
31-
// this.isSoldier = isSoldier;
32-
// this.id = nextId;
33-
// nextId++;
34-
// }
35-
36-
public int getAge() {
37-
return age;
38-
}
39-
40-
public void setAge(int age) {
41-
this.age = age;
42-
}
43-
44-
public String getName() {
45-
return name;
46-
}
47-
48-
public void setName(String name) {
49-
this.name = name;
50-
}
51-
52-
53-
public List<Human> getChildren() {
54-
return Collections.unmodifiableList(children);
55-
// return children;
56-
}
57-
58-
59-
// public void setChildren(List<Human> children) {
60-
// this.children = children;
61-
// }
62-
63-
public void addChild(Human child){
64-
children.add(child);
65-
}
66-
67-
public void removeChild(Human child){
68-
children.remove(child);
69-
}
70-
71-
public Human(String name, int age) {
72-
this.age = age;
73-
this.name = name;
74-
}
75-
76-
public int getId() {
77-
return id;
78-
}
79-
80-
public void printSize() {
81-
System.out.println("Рост: " + size[0] + " Вес: " + size[1]);
82-
}
83-
84-
@Override
85-
public void live() {
86-
87-
}
88-
89-
public void printData() {
90-
System.out.println(getPosition() + ": " + name);
91-
}
92-
93-
public String getPosition(){
94-
return "Человек";
95-
}
96-
}
7+
public class Human implements Alive {
8+
private static int nextId = 0;
9+
protected int age;
10+
protected String name;
11+
protected Size size;
12+
private int id;
13+
private BloodGroup bloodGroup;
14+
private List<Human> children = new ArrayList<>();
15+
16+
public Human(String name, int age) {
17+
this.age = age;
18+
this.name = name;
19+
}
20+
21+
public BloodGroup getBloodGroup() {
22+
return bloodGroup;
23+
}
24+
25+
public void setBloodGroup(BloodGroup bloodGroup) {
26+
this.bloodGroup = bloodGroup;
27+
}
28+
29+
public int getAge() {
30+
return age;
31+
}
32+
33+
public void setAge(int age) {
34+
this.age = age;
35+
}
36+
37+
public String getName() {
38+
return name;
39+
}
40+
41+
public void setName(String name) {
42+
this.name = name;
43+
}
44+
45+
public List<Human> getChildren() {
46+
return Collections.unmodifiableList(children);
47+
}
48+
49+
public void addChild(Human child) {
50+
children.add(child);
51+
}
52+
53+
public void removeChild(Human child) {
54+
children.remove(child);
55+
}
56+
57+
public int getId() {
58+
return id;
59+
}
60+
61+
public void printSize() {
62+
System.out.println("Рост: " + size.height + " Вес: " + size.weight);
63+
}
64+
65+
@Override
66+
public void live() {}
67+
68+
public void printData() {
69+
System.out.println(getPosition() + ": " + name);
70+
}
71+
72+
public String getPosition() {
73+
return "Человек";
74+
}
75+
76+
public class Size {
77+
public int height;
78+
public int weight;
79+
}
80+
}

3.JavaMultithreading/src/com/javarush/task/task29/task2909/human/Student.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ public class Student extends UniversityPerson {
1212

1313
public Student(String name, int age, double averageGrade) {
1414
super(name, age);
15-
// this.name = name;
16-
// this.age = age;
1715
this.averageGrade = averageGrade;
1816
}
1917

@@ -24,16 +22,9 @@ public void live() {
2422
public void learn() {
2523
}
2624

27-
// public void incAverageGradeBy01() {
28-
// averageGrade += 0.1;
29-
// }
30-
//
31-
// public void incAverageGradeBy02() {
32-
// averageGrade += 0.2;
33-
// }
34-
3525
public void incAverageGrade(double delta){
36-
averageGrade += delta;
26+
setAverageGrade(getAverageGrade() + delta);
27+
// averageGrade += delta;
3728
}
3829

3930
public void setCourse(int value){

3.JavaMultithreading/src/com/javarush/task/task29/task2909/human/Worker.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,16 @@
22

33
public class Worker extends Human{
44
private double salary;
5-
public String company;
5+
6+
public String getCompany() {
7+
return company;
8+
}
9+
10+
public void setCompany(String company) {
11+
this.company = company;
12+
}
13+
14+
private String company;
615

716
public Worker(String name, int age) {
817
super(name, age);

0 commit comments

Comments
 (0)