Added some tests for existing syntax as well as an up to date test coverage list. #8264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TFSMads
requested review from
TheMug06 and
cheeezburga
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
Efnilite
requested changes
Nov 1, 2025
src/test/java/org/skriptlang/skript/test/tests/syntaxes/effects/EffElytraBoostConsumeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/skriptlang/skript/test/tests/syntaxes/effects/EffMakeEggHatchTest.java
Outdated
Show resolved
Hide resolved
| To run individual test files, use <code>/sk test \<file\></code>. To run last | ||
| used file again, just use <code>/sk test</code>. | ||
|
|
||
| ## Test Coverage |
There was a problem hiding this comment.
this is bound to become outdated, should we keep it?
There was a problem hiding this comment.
I agree that it could potentially become outdated, but I still think it’s valuable to keep. The test coverage list provides a clear overview of what’s currently tested and helps identify missing tests, especially for new contributors. Even if it requires occasional updates, it serves as useful documentation for anyone working on improving test coverage.
…s/EffElytraBoostConsumeTest.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Skript project currently has very low test coverage for its existing syntax and no recent list of test coverage.
Solution
This PR adds tests for the following syntax:
This PR also adds an up to date list of test coverage.
Testing Completed
Tests have been tested on versions 1.20.6, 1.21.3, 1.21.4, 1.21.5, 1.21.8 and 1.21.10.
Supporting Information
Completes: none
Related: #6158