Skip to content

Verbose asserts for contains #8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dev/feature
Choose a base branch
from

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Jul 3, 2025

Problem

When writing a test with contains, if it failed, you would previously had to manually add a debug message to find the actual values passed.

Solution

Implements VerboseAsserts on CondContains. This adds extra info for the contains condition when it fails in a test, which avoids having to debug what the actual values are and what the expected values are.

image
image

Testing Completed

Tested using the CondContains tests, see screenshots.

Supporting Information


Completes: none
Related: none

@Efnilite Efnilite requested a review from a team as a code owner July 3, 2025 14:17
@Efnilite Efnilite requested review from cheeezburga and removed request for a team July 3, 2025 14:17
@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jul 3, 2025
@Efnilite Efnilite requested a review from erenkarakal July 3, 2025 14:17
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jul 3, 2025
@EquipableMC

This comment was marked as off-topic.

@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants