Fix Uncommon Arithmetic Type Errors #7907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APickledWalrus
added
the
bug
skriptlang-automation
bot
added
the
needs reviews
sovdeeth
approved these changes
Jun 1, 2025
UnderscoreTud
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's possible to for valid operations to fail, and more rarely, type exceptions to occur when using variables with arithmetic operations. This occurs when OperationInfo resolution is delayed to runtime, which is the case for variables.
Solution
This is caused by the resolved OperationInfo being saved for future executions (that is, the field on ArithmeticChain is updated). This unsafe (types can change, hence these issues), so I've updated the code to not modify the field. For future safety, I've made the field final.
Testing Completed
Additional tests in
ExprArithmetic.skwere added.Supporting Information
Completes: none
Related: none