Properly Check Nested Lists in LiteralUtils.hasUnparsedLiteral() #7850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erenkarakal
requested review from
APickledWalrus and
cheeezburga
and removed request for
a team
sovdeeth
added
the
bug
Efnilite
reviewed
May 6, 2025
src/test/skript/tests/regressions/7850-invalid nested list throws exception.sk
Outdated
Show resolved
Hide resolved
sovdeeth
approved these changes
May 12, 2025
APickledWalrus
approved these changes
May 12, 2025
APickledWalrus
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
send 1, (1, (abc))would throw aSkriptAPIExceptionbecause nested lists weren't properly checked.Target Minecraft Versions: any
Requirements: none
Related Issues: none