🛠 Fix toFormattedString for null nodes #5303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyhamAl-Ali
added
the
bug
AyhamAl-Ali
changed the title
AyhamAl-Ali
changed the title
TheLimeGlass
approved these changes
Jan 4, 2023
TPGamesNL
reviewed
Feb 5, 2023
| // Replace configured messages chat styles without user variables | ||
| String lineInfoMsg = replaceNewline(Utils.replaceEnglishChatStyles(lineInfo.getValue() == null ? lineInfo.key : lineInfo.getValue())); | ||
| String detailsMsg = replaceNewline(Utils.replaceEnglishChatStyles(details.getValue() == null ? details.key : details.getValue())); | ||
| String lineDetailsMsg = replaceNewline(Utils.replaceEnglishChatStyles(LINE_DETAILS.getValue() == null ? LINE_DETAILS.key : LINE_DETAILS.getValue())); | ||
|
|
||
| if (node == null) | ||
| return String.format(detailsMsg.replaceAll("(\\s){2,}", ""), message); // Remove line beginning spaces |
There was a problem hiding this comment.
Not sure if replacing 2+ whitespace is the best approach here.
Also the group isn't needed I think: \\s{2,}
There was a problem hiding this comment.
Adding upon what TP said, you can use String#stripLeading to remove the leading whitespaces in a string
There was a problem hiding this comment.
String#stripLeading Java 12 11 feature :(
Moderocky
approved these changes
Mar 20, 2023
UnderscoreTud
approved these changes
Apr 21, 2023
APickledWalrus
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes logger level color for messages that doesn't have a node.
Before:
After:
Target Minecraft Versions: Any
Requirements: None
Related Issues: None