Remove reloading difference async and sync loading #4252
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue in #4246 happens because async reloading is different from normal reloading. In normal reloading, the script is first unloaded, then it is loaded. In async reloading, the script is first loaded, then the old version is unloaded.
This behaviour was chosen because the server does not halt during async reloading and having the script unload first would mean there is a timeframe where the script is not running, and apparently this was unwanted behaviour.
In this PR I changed the async reloading behaviour, so that it unloads scripts first, then loads them (same as sync reloading).
This fixes the issue, but the disadvantage of this is that during script reloading commands or functions in the reloading scripts aren't available.
Target Minecraft Versions: any
Requirements: none
Related Issues: #4246