Skip to content

Add /skript command tab completer #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AyhamAl-Ali
Copy link
Member

Description

Add tab completions to /skript command

Support all arguments of /skript command
Support enabled, disabled and scripts to reload
Support folders and subdirectories
Respect hidden folders
Respect skript command permission


Target Minecraft Versions:
Requirements:
Related Issues: #3531

@AyhamAl-Ali
Copy link
Member Author

Is the build not processing because I used feature/ ?

@TPGamesNL TPGamesNL added 2.6 feature Pull request adding a new feature. labels Apr 24, 2021
Restored directories slash at the beginning to make Skript recognize them as directories and keep scripts in root folder without a slash
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :D

Copy link
Member

@TPGamesNL TPGamesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, when I try to tab /sk info, I can only do it when I haven't typed anything:
image
image
(same for other subcommands)

@AyhamAl-Ali AyhamAl-Ali requested a review from TPGamesNL November 4, 2021 08:28
@AyhamAl-Ali AyhamAl-Ali requested a review from TPGamesNL November 4, 2021 12:17
@AyhamAl-Ali AyhamAl-Ali requested a review from TPGamesNL November 5, 2021 19:02
@AyhamAl-Ali AyhamAl-Ali requested a review from TPGamesNL November 6, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants