Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling #142

Open
thomthom opened this issue Oct 8, 2014 · 1 comment
Open

Better error handling #142

thomthom opened this issue Oct 8, 2014 · 1 comment
Labels
Milestone

Comments

@thomthom
Copy link
Member

thomthom commented Oct 8, 2014

We should present an error message when importing junk files such as this one: https://dl.dropboxusercontent.com/u/4791584/SketchUp/STL/luer.stl

Reference:
http://forums.sketchup.com/t/stl-plugin-hung-up-at-importing-geometry/1793/6

@thomthom thomthom added the bug label Oct 8, 2014
@thomthom thomthom added this to the Version 2.2 milestone Oct 8, 2014
@jimfoltz
Copy link
Contributor

jimfoltz commented Dec 8, 2014

Also, if the stl file is less than 80 bytes, we get an Exception because file.read(4) returns nil, and then we try to call unpack on nil

https://github.com/SketchUp/sketchup-stl/blob/master/src/sketchup-stl/importer.rb#L161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants