Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] ComponentDefinition#manifold? #998

Open
Fredosixx opened this issue Aug 26, 2024 · 2 comments
Open

[Request] ComponentDefinition#manifold? #998

Fredosixx opened this issue Aug 26, 2024 · 2 comments
Labels
enhancement logged parity Missing functional parity with client Ruby API SketchUp

Comments

@Fredosixx
Copy link

Fredosixx commented Aug 26, 2024

This method ComponentDefinition#manifold? does not exist and would make sense.

It would avoid to either rely on an existing instance of the definition, or worse, create an temporary instance of the definition, just to check if the definition is manifold.

Note that there are cases where we can manipulate a definition that does not have an instance (yet).

  • when creating geometry (cdef = Sketchup.active_model.definitions.add, then adding entities to cdef.entities)
  • importing a definition from a skp file (definition#load)

The existing Group#manifold? and ComponentInstance#manifold? can continue to exist.

@thomthom thomthom added enhancement Ruby API SketchUp parity Missing functional parity with client labels Aug 27, 2024
@thomthom
Copy link
Member

That's a good point, having to have an instance to make that query.

@sketchup
Copy link

sketchup bot commented Sep 2, 2024

Logged as: SKEXT-4287

@sketchup sketchup bot added the logged label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement logged parity Missing functional parity with client Ruby API SketchUp
Projects
None yet
Development

No branches or pull requests

2 participants