Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_example should be renamed to a more appropriate template_example #246

Closed
fredrikhgrelland opened this issue Aug 20, 2020 · 0 comments · Fixed by #267
Closed

test_example should be renamed to a more appropriate template_example #246

fredrikhgrelland opened this issue Aug 20, 2020 · 0 comments · Fixed by #267
Assignees
@pdmthorsrud
Labels
theme/template Related to vagrant-hashistack-template type/documentation Improvements or additions to documentation type/enhancement New feature or request

Comments

@fredrikhgrelland
Copy link
Contributor

When reviewing #242 I saw test_example mentioned in the context of being an example of the template. It looks out of place. template_example however is descriptive and fits.
@fredrikhgrelland fredrikhgrelland added type/documentation Improvements or additions to documentation type/enhancement New feature or request theme/template Related to vagrant-hashistack-template labels Aug 20, 2020
@pdmthorsrud pdmthorsrud mentioned this issue Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdmthorsrud pdmthorsrud

Labels
theme/template Related to vagrant-hashistack-template type/documentation Improvements or additions to documentation type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Template README refactor Skatteetaten/vagrant-hashistack
2 participants
@fredrikhgrelland @pdmthorsrud