Lazily derive the huffman tables. Fix #839#841
Merged
JimBobSquarePants merged 4 commits intomasterfrom Feb 23, 2019
Merged
Conversation
antonfirsov
requested changes
Feb 20, 2019
Member
antonfirsov
left a comment
antonfirsov
left a comment
There was a problem hiding this comment.
Just a minor finding, otherwise everything looks good.
Codecov Report
@@ Coverage Diff @@
## master #841 +/- ##
==========================================
+ Coverage 88.87% 88.88% +<.01%
==========================================
Files 1015 1014 -1
Lines 44240 44272 +32
Branches 3202 3206 +4
==========================================
+ Hits 39319 39349 +30
- Misses 4200 4201 +1
- Partials 721 722 +1
Continue to review full report at Codecov.
|
antonfirsov
approved these changes
Feb 23, 2019
Member
antonfirsov
left a comment
antonfirsov
left a comment
There was a problem hiding this comment.
Based on my current limited understanding, everything looks good.
I'm trusting our coverage more than my eyes now.
antonfirsov
pushed a commit
to antonfirsov/ImageSharp
that referenced
this pull request
Nov 11, 2019
* Lazily derive the huffman tables. Fix SixLabors#839 * Lazy invoke fast table * Add performance tweaks to scan decoder. * Remove unneccessary classes.
This was referenced Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
libjpeg and co avoid bad remaining counts when reading the huffman table marker by leaving derivation until they reach the SOS segment and it's time to decode. We now do the same.