GDI+ stability fixes for the benchmark and tests#835
Merged
JimBobSquarePants merged 1 commit intoSixLabors:masterfrom Feb 15, 2019
Lakritzator:master
Merged
GDI+ stability fixes for the benchmark and tests#835JimBobSquarePants merged 1 commit intoSixLabors:masterfrom Lakritzator:master
JimBobSquarePants merged 1 commit intoSixLabors:masterfrom
Lakritzator:master
Conversation
…table, this should hopefully prevent "a generic error occurred in GDI+". Hopefully I didn't miss one...
Member
|
@Lakritzator Ah this is great! 👍 |
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
==========================================
+ Coverage 88.84% 88.84% +<.01%
==========================================
Files 1015 1015
Lines 44167 44169 +2
Branches 3181 3181
==========================================
+ Hits 39241 39243 +2
Misses 4201 4201
Partials 725 725
Continue to review full report at Codecov.
|
Contributor
Author
|
I'm not sure how reproducible the problems were, but I guess I didn't make it worse. Just let me know when you see the issue again, and I will have a more thorough look! But my gut feeling tells me I got all... |
Contributor
Author
|
P.S. I like the automation you did, I really should use this CLAassistant too... |
JimBobSquarePants
approved these changes
Feb 15, 2019
This was referenced Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Some changes to make the usages of GDI in benchmarks and tests more stable, this should hopefully prevent "a generic error occurred in GDI+". Hopefully I didn't miss one...
If you new Pen, Brush or Fonts, these need to be disposed.