Respecting fileHeader Offset, skipping bytes if necessary#819
Merged
JimBobSquarePants merged 3 commits intoSixLabors:masterfrom Feb 5, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #819 +/- ##
==========================================
+ Coverage 88.65% 88.74% +0.08%
==========================================
Files 1015 1015
Lines 44120 44130 +10
Branches 3178 3180 +2
==========================================
+ Hits 39116 39164 +48
+ Misses 4241 4237 -4
+ Partials 763 729 -34
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #819 +/- ##
=========================================
- Coverage 88.8% 88.8% -0.01%
=========================================
Files 1015 1015
Lines 44138 44148 +10
Branches 3178 3180 +2
=========================================
+ Hits 39198 39206 +8
- Misses 4211 4212 +1
- Partials 729 730 +1
Continue to review full report at Codecov.
|
Member
|
@brianpopow Again amazing work, you rock! 👍 |
antonfirsov
pushed a commit
to antonfirsov/ImageSharp
that referenced
this pull request
Nov 11, 2019
This was referenced Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The file header offset is ignored, which indicates where the image data starts. This can cause incorrectly decoded images.
This PR changes this and unused bytes between the palette and the image will be skipped.