Skip to content

Conversation

@antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Apr 29, 2018

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

  • Renamed ImageSharp.Tests/Drawing/BlendedShapes to SolidFillBlendedShapesTests
  • Verbose, but descriptive test names
  • Removing noise from output image file names
  • Assertions through reference images

Having this merged will make merging #552 safer.

@codecov
Copy link

codecov bot commented Apr 29, 2018

Codecov Report

Merging #553 into master will decrease coverage by 0.02%.
The diff coverage is 98.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
- Coverage   88.16%   88.14%   -0.03%     
==========================================
  Files         838      838              
  Lines       34974    35036      +62     
  Branches     2529     2532       +3     
==========================================
+ Hits        30836    30883      +47     
+ Misses       3394     3393       -1     
- Partials      744      760      +16
Impacted Files Coverage Δ
...Sharp.Tests/Drawing/SolidFillBlendedShapesTests.cs 100% <100%> (ø)
...ts/ImageSharp.Tests/Formats/Png/PngEncoderTests.cs 97.67% <100%> (ø) ⬆️
...harp.Tests/TestUtilities/ImagingTestCaseUtility.cs 96.55% <100%> (+6.73%) ⬆️
...geSharp.Tests/TestUtilities/TestImageExtensions.cs 80.76% <77.77%> (+0.1%) ⬆️
src/ImageSharp/Common/Helpers/ImageMaths.cs 77.41% <0%> (-6.46%) ⬇️
...sing/Dithering/ErrorDiffusion/ErrorDiffuserBase.cs 93.1% <0%> (-3.45%) ⬇️
...Formats/Jpeg/GolangPort/Components/Decoder/Bits.cs 69.69% <0%> (-3.04%) ⬇️
...arp.Tests/TestUtilities/TestEnvironment.Formats.cs 87.87% <0%> (-3.04%) ⬇️
.../ImageSharp.Tests/TestUtilities/TestEnvironment.cs 82.5% <0%> (-2.5%) ⬇️
...c/ImageSharp/Formats/Png/Zlib/ZlibDeflateStream.cs 61.4% <0%> (-1.76%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87103b7...34ed38d. Read the comment docs.

Copy link
Member

@tocsoft tocsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@tocsoft tocsoft merged commit 01d0426 into master Apr 30, 2018
@tocsoft tocsoft deleted the af/drawing-tests branch April 30, 2018 07:54
antonfirsov pushed a commit to antonfirsov/ImageSharp that referenced this pull request Nov 11, 2019
Better test coverage for SolidBrush + blenders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants