Skip to content

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Uses the computed BitsPerPixel from the color writer instance for the compressor to ensure parity.

Fixes #2909

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the TIFF compressor initialization to use the computed BitsPerPixel from the color writer, ensuring parity between the compressor and the color writer. Key changes include:

  • Defining a new test image constant for Issue2909.
  • Adding new test cases for LZW and Deflate compression using the Issue2909 file.
  • Updating the TiffEncoderCore to obtain BitsPerPixel from the color writer instead of from the encoder instance.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
tests/ImageSharp.Tests/TestImages.cs Added constant for Issue2909 test image.
tests/ImageSharp.Tests/Formats/Tiff/TiffEncoderTests.cs Added test cases for LZW and Deflate compression using Issue2909.
src/ImageSharp/Formats/Tiff/TiffEncoderCore.cs Changed compressor initialization to use colorWriter.BitsPerPixel.
Files not reviewed (1)
  • tests/Images/Input/Tiff/Issues/Issue2909.tiff: Language not supported

@JimBobSquarePants JimBobSquarePants merged commit 5d8c199 into release/3.1.x Apr 26, 2025
22 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/v3-fix-2909 branch April 26, 2025 11:00
This was referenced Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant