[fix]: Fixed Unknown App0 Marker add profileResolver missing

[JoseEliasSantos]

Prerequisites

• I have written a descriptive pull-request title
• I have verified that there are no overlapping pull-requests open
• I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
• I have provided test coverage for my change (where applicable)

Description

Fixed discussion and issue bug
https://github.com/SixLabors/ImageSharp/discussions/2564
https://github.com/SixLabors/ImageSharp/issues/2565

[CLAassistant]

All committers have signed the CLA.

[JimBobSquarePants]

While this works, I'm not sure it's the correct fix.

I think we might be able to simply remove the throw when the marker doesn't match a JFIF one and skip the remaining bytes.

What is OSQidMaker? Can you please supply more information?

[JoseEliasSantos]

In fact, in my research I didn't find markers that specified such a conversion starting with these bytes, but I have images of a camera that always has these bytes at the beginning. I also had success in all tests when ignoring this if but I don't know what more problems this could cause. I'm running a fork of the lib in my application and I don't get any more errors

[JimBobSquarePants]

The JFIF JFXX headers contain metadata and we can actually operate without them. Your images actually contain a JFIF header in an APP0 block just after the camera junk.

I can’t accept the fix as-is because the values are non-standard so we should try a more robust solution as suggested

[gfoidl]

Suggested change

	public static ReadOnlySpan<byte> OSQidMaker => new[]
	{
	(byte)'\n', (byte)'[', (byte)'I', (byte)'D', (byte)' '
	};
	public static ReadOnlySpan<byte> OSQidMaker => new[] { (byte)'\n', (byte)'[', (byte)'I', (byte)'D', (byte)' ' };

I'd like to have it written as one-liner, because when we are able to use ut8-literals it's easier to find & replace these.

[JoseEliasSantos]

It's a good suggestion, but the other properties of the class already follow this same pattern, so I chose to keep it.

[JimBobSquarePants]

Hi @JoseEliasSantos I can see you updated your PR from main. As commented, we won't be able to proceed #2566 (comment) with the fix you have applied. If you are not able to make the suggested changes, that's OK. I can close this and create a new PR.

[JimBobSquarePants]

I've made the required changes here to make JFIF marker optional. Thanks for your assistance here 🙂