Skip to content

naming corrections - macOS and .NET #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mikeirvingweb
Copy link
Contributor

Naming corrections to macOS and .NET

Written (comments, debug comments, readme etc) ...

renamed:

  • MacOSX -> macOS
  • MacOs -> macOS
  • OSX -> macOS
  • .Net -> .NET

Code ...

renamed:

  • IsNotMacOs -> IsNotMacOS
  • InvokeMacOSX -> InvokeMacOS
  • TestEnvironment.IsOSX -> TestEnvironment.IsMacOS

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2022

CLA assistant check
All committers have signed the CLA.

@JimBobSquarePants
Copy link
Member

Sorry @mikeirvingweb I just broken your PR by merging in a change from main that still referenced the old naming. Would you be able to update your end? Thanks!

@mikeirvingweb
Copy link
Contributor Author

mikeirvingweb commented Mar 15, 2022 via email

Copy link
Contributor Author

@mikeirvingweb mikeirvingweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correction to repair breaking change from another merge

@JimBobSquarePants JimBobSquarePants merged commit 2bedf20 into SixLabors:main Mar 15, 2022
@JimBobSquarePants
Copy link
Member

Thanks for the naming fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants